Skip to content

[FEATURE] create @perses-dev/design-tokens package - #198

Merged
jgbernalp merged 2 commits into
perses:ui-customizationfrom
zhuje:ui-customization
Jul 9, 2026
Merged

[FEATURE] create @perses-dev/design-tokens package#198
jgbernalp merged 2 commits into
perses:ui-customizationfrom
zhuje:ui-customization

Conversation

@zhuje

@zhuje zhuje commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Description

Create @perses-dev/design-tokens as part of this initiative perses/perses#3570

Screenshots

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@zhuje
[FEATURE] create @perses-dev/design-token package
7f5b2cd 
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
jgbernalp
jgbernalp reviewed Jul 8, 2026
View reviewed changes
Comment thread design-tokens/src/css/semantic.css Outdated
jgbernalp
jgbernalp reviewed Jul 8, 2026
View reviewed changes
Comment thread design-tokens/src/test/setup-tests.ts Outdated

@jgbernalp jgbernalp Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is empty, do we need it?

@zhuje zhuje Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

jgbernalp
jgbernalp reviewed Jul 8, 2026
View reviewed changes
Comment thread design-tokens/src/css/semantic.css Outdated
jgbernalp
jgbernalp reviewed Jul 8, 2026
View reviewed changes
Comment thread design-tokens/src/tokens.ts Outdated
jgbernalp
jgbernalp reviewed Jul 8, 2026
View reviewed changes
Comment thread design-tokens/src/css/semantic.css Outdated
jgbernalp
jgbernalp reviewed Jul 8, 2026
View reviewed changes
Comment thread design-tokens/package.json Outdated
@zhuje
[IGNORE] address comments perses/shared pr perses#198
84f3ea9 
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
@zhuje
zhuje requested a review from jgbernalp July 8, 2026 20:06
@jgbernalp
jgbernalp merged commit 264677b into perses:ui-customization Jul 9, 2026
12 checks passed
zhuje added a commit that referenced this pull request Aug 5, 2026
@zhuje
[FEATURE] create @perses-dev/design-tokens package (#198)
3ca3f2d 
* [FEATURE] create @perses-dev/design-token package

Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>

* [IGNORE] address comments perses/shared pr #198

Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>

---------

Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgbernalp jgbernalp jgbernalp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhuje @jgbernalp